Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clear offset when crossing flash pages #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

clear offset when crossing flash pages #89

wants to merge 1 commit into from

Conversation

tlyu
Copy link

@tlyu tlyu commented Jun 6, 2022 •
edited
Loading

When doing a flash read that crosses pages, clear the offset once the first page is read. Otherwise, GDB will receive incorrect bytes, and the read can overrun the page cache buffer.

Fixes #106.

@tlyu tlyu mentioned this pull request Jun 6, 2022
Open
@tlyu tlyu mentioned this pull request Dec 28, 2023
Open
@tlyu
clear offset when crossing flash pages
414ce3f 
When doing a flash read that crosses pages, clear the offset once
the first page is read. Otherwise, GDB will receive incorrect bytes, and
the read can overrun the page cache buffer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DebugWire flash reads cause buffer overruns, incorrect results
1 participant
@tlyu