New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: output: array never uses fullform #119

Closed

carlos22 opened this issue Aug 19, 2020 · 0 comments · Fixed by #128

carlos22 commented Aug 19, 2020 •

edited

Loading

See:

filesize.js/lib/filesize.js

Lines 152 to 158 in 5aee55b

    
           if (output === "array") { 
        
             return result; 
        
           } 
        
           if (full) { 
        
             result[1] = fullforms[e] ? fullforms[e] : fullform[standard][e] + (bits ? "bit" : "byte") + (result[0] === 1 ? "" : "s");

This returns before the fullform is generated.

carlos22 changed the title ~~Bug: output: array never uses fullform~~ bug: output: array never uses fullform

avoidwork mentioned this issue

Fixing array output such that fullform is a potential output #128

Merged

1 task

avoidwork closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment