Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to fallback to properties file in the case of unit test environment #2

Open
TimGonz-AVIO opened this issue Mar 13, 2020 · 2 comments · Fixed by #18
Open
Assignees
Labels
enhancement New feature or request

Comments

@TimGonz-AVIO
Copy link

I attempted to run a MUnit test with an app configured to use the Vault properties provider without having a connection to the Vault instance (and also without having the specific property available but the Vault instance running). I received an error like the following:

Couldn't find configuration property value for key ${vault::secret/url.path}

It listed trying to use environment properties provider and configuration-attribute provider composed of (Vault properties provider, <configuration-properties file="test.properties"> ...). I created a test properties file containing the following key/value pairs in an attempt to help it resolve the property with no luck:

secret/url.path=get
vault::secret/url.path=get
"vault::secret/url.path"=get

Could we include a fallback to property file resolution within the Vault properties provider in the case of situations like this? My thought is that if a Jenkins server was running in isolation from the environments where the Vault instances were running, or in the case you're running locally and don't have access to the Vault instances.

@adesjardin adesjardin added the enhancement New feature or request label Mar 13, 2020
@Kevin44
Copy link

Kevin44 commented Aug 15, 2022

Is this something that is going to be worked on in the future or has it been put on hold indefinitely. My company would like this option and have been considering writing something ourselves. Thanks!

@adesjardin
Copy link
Contributor

@Kevin44 - This feature is in progress actually and should be complete/merged later this week

@adammead adammead linked a pull request Sep 2, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants