Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factorial simp example #132

Open
PatrickMassot opened this issue Oct 2, 2023 · 1 comment
Open

factorial simp example #132

PatrickMassot opened this issue Oct 2, 2023 · 1 comment

Comments

@PatrickMassot
Copy link
Collaborator

In Chapter 5, we have

example : fac 0 = 1 := by
  simp [fac]

which is misleading since giving [fac] plays no role.

@avigad
Copy link
Owner

avigad commented Oct 22, 2023

@PatrickMassot Is this a problem? The example right before shows that this particular case is solved by rfl. But, more generally, simp [fac] will replace fac 0 by 1 in any context. It seems strange to modify the example just to make that point.

A bigger issue is that we now only have a minimal discussion of decide in 5.3, and we never say that simp calls decide. Shall we replace this issue by a separate issue that says that we should expand the discussion of decide?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants