Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select hash for context and SHA1 & MD5 #136

Open
ruppde opened this issue Oct 3, 2023 · 1 comment
Open

Select hash for context and SHA1 & MD5 #136

ruppde opened this issue Oct 3, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ruppde
Copy link
Contributor

ruppde commented Oct 3, 2023

Hello,

at the moment, the 🔍 "Select hash for context" is shown over all hashes, but it only works for SHA256. Best solution would of course be to also support MD5 & SHA1. (Should be easy as it only searches for the name?)
@MatejKastak
Copy link
Member

Yes, this would be a nice improvement.

@MatejKastak MatejKastak transferred this issue from avast/yari Oct 3, 2023
@MatejKastak MatejKastak added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Oct 3, 2023
ruppde added a commit to ruppde/yls that referenced this issue Oct 4, 2023
@ruppde
Select hash for context and SHA1 & MD5, solve issue avast#136
cfb45d7 
New:  Select hash for context and SHA1 & MD5
New: Case ignore in hashes, because why not
Bugfix: Only show "Select hash for context" next to valid hashes

Solve avast#136
@ruppde ruppde mentioned this issue Oct 4, 2023
Merged
MatejKastak pushed a commit to ruppde/yls that referenced this issue Oct 23, 2023
@ruppde @MatejKastak
Select hash for context and SHA1 & MD5, solve issue avast#136
4505ba1 
New:  Select hash for context and SHA1 & MD5
New: Case ignore in hashes, because why not
Bugfix: Only show "Select hash for context" next to valid hashes

Solve avast#136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MatejKastak @ruppde