Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugs.idioms-reg-couples.TestCryptoLocker expects issue #41 to be present #12

Closed
palant opened this issue Sep 11, 2018 · 3 comments
Closed
Labels

Comments

@palant
Copy link

palant commented Sep 11, 2018

https://github.com/avast-tl/retdec-regression-tests/blob/72243c8700bb3dcbf6ffc118180998fcae8e832b/bugs/idioms-reg-couples/test.py#L1669 asserts that function_40edd0 calls abort(). However, there is no such call in this function. The abort() call here is the result of avast/retdec#41, and fixing the issue (avast/retdec#391) makes the test fail. This assert should be removed.

@s3rvac s3rvac added the bug label Sep 13, 2018
@s3rvac
Copy link
Member

s3rvac commented Sep 13, 2018

This is most probably an oversight and the check for abort() in function_40edd0 should be removed. Right @PeterMatula?

@palant
Copy link
Author

palant commented Sep 13, 2018

Alternatively, we could wait for avast/retdec#391 to be merged and negate that check - that abort() call should not be there.

@PeterMatula
Copy link
Collaborator

It is very probable. I will look into this shortly (today/tomorrow).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants