-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ServiceInfos expect container name with specific format. #81
Comments
By default, container name is constructed from projectName and Container name, so it adds some complexity on querying service infos, You kind of have to take in to account what the full name will look like. In tests it would be something ugly like |
Exactly - having hard-coded container name doesn't make sense in automated testing scenarios because it could easily collide on integration server etc. Anyway, it would be nice to support also your use-case. I will look at it how complicated it would be. E.g. we could check in the YAML file if |
Thanks @augi |
Released as 0.4.3. |
If I add
container_name
as part of mydocker-compose.yml
file then I am not able to calldockerCompose.servicesInfos.<service_name>.'<container_name>'
. Looking at the code, the reason is due to this. In case thecontainer_name
is set then the pattern does not match. Is there a need for the pattern check ? Maybe I am missing something, is there anything wrong if we just use the value ofinspection.Name
excluding the/
?The text was updated successfully, but these errors were encountered: