Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Observable #84

Closed
sindresorhus opened this issue Oct 19, 2015 · 5 comments
Closed

Support Observable #84

sindresorhus opened this issue Oct 19, 2015 · 5 comments
Labels

Comments

@sindresorhus
Copy link
Member

Re mochajs/mocha#1898

https://github.com/zenparsing/es-observable

@thejameskyle What do we need to do to support it?

I would guess calling .forEach() on the observable as that returns a promise.

@jamiebuilds
Copy link
Contributor

https://github.com/phated/async-done

This is the library used to resolve several different async types in gulp 4.0 (streams, promises, observables). You might want to make use of it.

cc @Blesh

@benlesh
Copy link

benlesh commented Oct 20, 2015

I don't think that async-done library supports RxJS 5 observables yet. The better path is to look for Symbol.observable on any incoming object, then call it and call subscribe on whatever object you get back. This will make it work with Kefir, Most and Bacon now as well I think.

@sindresorhus
Copy link
Member Author

@Blesh Can you open an issue/PR on async-done?

@benlesh
Copy link

benlesh commented Nov 12, 2015

@Blesh Can you open an issue/PR on async-done?

Sorry, this got lost in my GitHub inbox... Does this still need to happen? I'm not sure i have time to do the PR anytime soon, unfortunately.

@sindresorhus
Copy link
Member Author

@Blesh Not really. We just went with adding support for it directly in AVA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants