Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVA hangs when test is used incorrectly #574

Closed
novemberborn opened this issue Feb 26, 2016 · 5 comments
Closed

AVA hangs when test is used incorrectly #574

novemberborn opened this issue Feb 26, 2016 · 5 comments
Labels
enhancement new functionality

Comments

@novemberborn
Copy link
Member

Did some preliminary testing and would seem that code like this causes AVA to hang:

import test from 'ava'

test()

Incorrect invocations like these should have better user feedback too.

@novemberborn novemberborn self-assigned this Feb 26, 2016
@sindresorhus sindresorhus added enhancement new functionality accepted labels Feb 26, 2016
@sotojuan
Copy link
Contributor

I'd like to work on this—would this just require a check on test()'s arguments and an appropriate error message?

@vadimdemedes
Copy link
Contributor

@sotojuan Seems like, try and see :)

@novemberborn
Copy link
Member Author

I'd like to work on this

@sotojuan yes that'd be great!

would this just require a check on test()'s arguments and an appropriate error message?

Yea I think so. It's pretty weird right now, using the mini reporter it just hung, and using --verbose it got stuck in a loop complaining about the test() call causing an error to be thrown. Besides adding some assertions around required usage and communicating that back to the user I'm rather curious why it got stuck.

@novemberborn novemberborn removed their assignment Feb 28, 2016
@sotojuan
Copy link
Contributor

All right, I'll take a look at it later today or Monday. I have an algorithms exam to study for!

@novemberborn
Copy link
Member Author

@sotojuan good luck with your exam!

Also note that #565 is already adding some of these messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new functionality
Projects
None yet
Development

No branches or pull requests

4 participants