Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide our own error stack on IPC messaged errors #269

Closed
sindresorhus opened this issue Nov 25, 2015 · 3 comments
Closed

Hide our own error stack on IPC messaged errors #269

sindresorhus opened this issue Nov 25, 2015 · 3 comments
Labels
enhancement new functionality help wanted

Comments

@sindresorhus
Copy link
Member

From: #245 (comment)

Our error stack is pretty useless when an error comes from the forked process.
@sindresorhus sindresorhus added enhancement new functionality accepted labels Nov 25, 2015
@jamestalmage
Copy link
Contributor

Agreed.

I think the best solution is to stop rejecting the promise in that case. Rejection has the side affect of bailing out of Promise.all early, so other test files may not finish. We should resolve with an failure result, that will simply be summarized in the output. We should save rejection for unexpected/unrecoverable problems.

@sindresorhus
Copy link
Member Author

We should resolve with an failure result, that will simply be summarized in the output. We should save rejection for unexpected/unrecoverable problems.

👍

@novemberborn
Copy link
Member

Pretty sure this has been addressed in various ways. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement new functionality help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@novemberborn @sindresorhus @jamestalmage