-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer working on Node.js 0.10 #154
Comments
@sindresorhus most likely, because this line rejects to |
Yup, but I'm unsure why. That test should pass, but it's rejecting somehow. |
@sindresorhus probably because we kill process after all tests are done - and sometimes Node.js 0.10 will return |
Should we be sending a different kill signal? https://nodejs.org/api/process.html#process_signal_events
Maybe the forks should just be in charge of terminating themselves. |
Not sure why the tests didn't catch this.
// @floatdrop
The text was updated successfully, but these errors were encountered: