Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miguel/ava 141 hard fork on plonk update 3 #96

Merged
merged 17 commits into from
Oct 13, 2022

Conversation

MiguelDD1
Copy link
Contributor

@MiguelDD1 MiguelDD1 commented Oct 11, 2022

Plonk updates from 0.8.2 to 0.12.0

This hard-fork upgrade adds a new version of hosted function header_builder_build. The new version uses kate-0.2.0 which depends on dusk-plonk-0.12.0.

Primitives & Kate moved to avail-core repo

We moved these crates into the external repo avail-core. That facilitates the use of several versions of Kate. Particularly we are using:

  • Kate:0.1.0 on runtime with spec version == 4.
  • Kate:0.2.0 on runtime with spec version == 5.

    - `Kate` & `da-primitives` have been moved out to another repo.
    - New version of `header_builder::build` which uses `Kate 0.2.0`.
      Version 1 is still available.
    - `Kate` & `da-primitives` have been moved out to another repo.
    - New version of `header_builder::build` which uses `Kate 0.2.0`.
      Version 1 is still available.
…-miguelDD1:maticnetwork/avail into miguel/ava-141-hard-fork-on-plonk-update
    - `Kate` & `da-primitives` have been moved out to another repo.
    - New version of `header_builder::build` which uses `Kate 0.2.0`.
      Version 1 is still available.
…-miguelDD1:maticnetwork/avail into miguel/ava-141-hard-fork-on-plonk-update
@linear
Copy link

linear bot commented Oct 11, 2022

AVA-141 Hard Fork on Plonk update

Update our Plonk dependency and upgrade the DevNet using a hard-fork approach (research how to do it on Substrate).

Acceptance Criteria:

  • Documentation for Soft-fork (a.k.a Runtime Upgrade)
  • Documentation for Hard-fork.

@MiguelDD1 MiguelDD1 marked this pull request as ready for review October 11, 2022 14:58
@MiguelDD1 MiguelDD1 requested review from a team October 11, 2022 15:02
@MiguelDD1 MiguelDD1 self-assigned this Oct 11, 2022
components: rustfmt
profile: minimal

- name: Install Rust toolchain 1.64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would beneficial if we have short comment for reasoning behind this change (hopefully someone will check in the future and improve it 🤷 ). Btw, PR from note above is still not merged :D

@MiguelDD1 MiguelDD1 merged commit d6d79cf into develop Oct 13, 2022
@MiguelDD1 MiguelDD1 deleted the miguel/ava-141-hard-fork-on-plonk-update_3 branch October 13, 2022 14:38
luka-ethernal pushed a commit that referenced this pull request Nov 9, 2022
* Header builder can use `Kate 0.1.0` and `0.2.0`

    - `Kate` & `da-primitives` have been moved out to another repo.
    - New version of `header_builder::build` which uses `Kate 0.2.0`.
      Version 1 is still available.

* `Kate` deps to tags and bump RT version

* Keep unstable fmt

* Add 1.64 toolchain to git workflow

* Coverage support on stable compiler

* Header builder can use `Kate 0.1.0` and `0.2.0`

    - `Kate` & `da-primitives` have been moved out to another repo.
    - New version of `header_builder::build` which uses `Kate 0.2.0`.
      Version 1 is still available.

* `Kate` deps to tags and bump RT version

* Keep unstable fmt

* Add 1.64 toolchain to git workflow

* Coverage support on stable compiler

* Header builder can use `Kate 0.1.0` and `0.2.0`

    - `Kate` & `da-primitives` have been moved out to another repo.
    - New version of `header_builder::build` which uses `Kate 0.2.0`.
      Version 1 is still available.

* `Kate` deps to tags and bump RT version

* Keep unstable fmt

* Coverage support on stable compiler

* Update `Kate/v0.2.1`
MiguelDD1 added a commit that referenced this pull request Nov 9, 2022
* Use substrate v0.9.29 - Partial

* Revert "Bump Runtime and Node versions (#88)"

This reverts commit 86af7d1.

* Revert "Use substrate v0.9.29 - Partial"

This reverts commit 58d4a96.

* Add nomad v1 pallets (#84)

* add nomad primitives

* patch dependencies to fix build issues

* remove tiny keccak from merkle

* add tiny keccak back to merkle and use to avoid extra allocation in left/right hash

* port nomad pallets, build failing

* add node and runtime changes

* add subxt changes

* fix compact block header and add specs to node for genesis info

* add new script for submitting data and header

* rename enqueue_data_root to dispatch_data_root

* rebase on primitive changes and change da-bridge message and TypedMessage to use BoundedVec

* fix failing home test after max message len change

* rebase on merged primitives

* remove unnecessary methods and add da-bridge docs

* update metadata and have home tree put default

* make da-bridge message type struct-based not vector-based

* remove panic in da bridge message

* remove finalized block hash mapping

* fix vec dependency after rebase on post-primitives PR

* make non body length public for tests

* Safety review

* Add benchmarks to `Nomad-home`

* Code review changes

  - New Benchmarks for `nomad/da-bridge`
  - Add header hash to `try_dispatch_data_root`.
  - Add assertions to `verify` section in benchmarks.

* Update `avail-subxt` examples

* Full header is needed

* Fmt fix

* fix double import and missing let after rebase

* fix subxt scripts with new da-bridge header metadata

* fix home update pallet weight

Co-authored-by: Miguel <[email protected]>
Co-authored-by: miguelDD1 <[email protected]>

* release change

* Miguel/ava 141 hard fork on plonk update 3 (#96)

* Header builder can use `Kate 0.1.0` and `0.2.0`

    - `Kate` & `da-primitives` have been moved out to another repo.
    - New version of `header_builder::build` which uses `Kate 0.2.0`.
      Version 1 is still available.

* `Kate` deps to tags and bump RT version

* Keep unstable fmt

* Add 1.64 toolchain to git workflow

* Coverage support on stable compiler

* Header builder can use `Kate 0.1.0` and `0.2.0`

    - `Kate` & `da-primitives` have been moved out to another repo.
    - New version of `header_builder::build` which uses `Kate 0.2.0`.
      Version 1 is still available.

* `Kate` deps to tags and bump RT version

* Keep unstable fmt

* Add 1.64 toolchain to git workflow

* Coverage support on stable compiler

* Header builder can use `Kate 0.1.0` and `0.2.0`

    - `Kate` & `da-primitives` have been moved out to another repo.
    - New version of `header_builder::build` which uses `Kate 0.2.0`.
      Version 1 is still available.

* `Kate` deps to tags and bump RT version

* Keep unstable fmt

* Coverage support on stable compiler

* Update `Kate/v0.2.1`

* Header Forward Compatibility (#99)

* Use new versioned header extensions
* Data Root without hardcode decoding

* Fix header format for avail-subxt.

* Miguel/ava 405 rpc not working with scripts (#102)

* Use custom branch

* Use header extensions

* Fix fmt

* Data Root without hardcode decoding

* Use `avail-core` tag

* Bump `avail-core` dep

* Comment from codereview

* RPC minor fixes

* Use temporay branch for `avail-core`

* RPC `query_data_proof` uses runtime extractor

* Rollback to tagged `avail-core` & disable VTest

* Update `avail-core` deps

* Fix `BlockLength` decodification bug

* Data Proof RPC uses block instead runtime

* Fix header format for avail-subxt. (#103)

* Use `subxt-cli` to generate `api_dev.rs`

* New E2E tool: Run examples using an avail-node

* Add `README.md`

* Fix some merge issues

* Update `avail-subxt` doc

* Add decoding support to Extrinsics

* Bump some version

* Increase Epoch to 1h (#108)

* Uses the right version of `subxt` (#109)

* Empty-Commit

* Use substrate v0.9.29 - Partial

* Revert "Bump Runtime and Node versions (#88)"

This reverts commit 86af7d1.

* Revert "Use substrate v0.9.29 - Partial"

This reverts commit 58d4a96.

* Add nomad v1 pallets (#84)

* add nomad primitives

* patch dependencies to fix build issues

* remove tiny keccak from merkle

* add tiny keccak back to merkle and use to avoid extra allocation in left/right hash

* port nomad pallets, build failing

* add node and runtime changes

* add subxt changes

* fix compact block header and add specs to node for genesis info

* add new script for submitting data and header

* rename enqueue_data_root to dispatch_data_root

* rebase on primitive changes and change da-bridge message and TypedMessage to use BoundedVec

* fix failing home test after max message len change

* rebase on merged primitives

* remove unnecessary methods and add da-bridge docs

* update metadata and have home tree put default

* make da-bridge message type struct-based not vector-based

* remove panic in da bridge message

* remove finalized block hash mapping

* fix vec dependency after rebase on post-primitives PR

* make non body length public for tests

* Safety review

* Add benchmarks to `Nomad-home`

* Code review changes

  - New Benchmarks for `nomad/da-bridge`
  - Add header hash to `try_dispatch_data_root`.
  - Add assertions to `verify` section in benchmarks.

* Update `avail-subxt` examples

* Full header is needed

* Fmt fix

* fix double import and missing let after rebase

* fix subxt scripts with new da-bridge header metadata

* fix home update pallet weight

Co-authored-by: Miguel <[email protected]>
Co-authored-by: miguelDD1 <[email protected]>

* release change

* Miguel/ava 141 hard fork on plonk update 3 (#96)

* Header builder can use `Kate 0.1.0` and `0.2.0`

    - `Kate` & `da-primitives` have been moved out to another repo.
    - New version of `header_builder::build` which uses `Kate 0.2.0`.
      Version 1 is still available.

* `Kate` deps to tags and bump RT version

* Keep unstable fmt

* Add 1.64 toolchain to git workflow

* Coverage support on stable compiler

* Header builder can use `Kate 0.1.0` and `0.2.0`

    - `Kate` & `da-primitives` have been moved out to another repo.
    - New version of `header_builder::build` which uses `Kate 0.2.0`.
      Version 1 is still available.

* `Kate` deps to tags and bump RT version

* Keep unstable fmt

* Add 1.64 toolchain to git workflow

* Coverage support on stable compiler

* Header builder can use `Kate 0.1.0` and `0.2.0`

    - `Kate` & `da-primitives` have been moved out to another repo.
    - New version of `header_builder::build` which uses `Kate 0.2.0`.
      Version 1 is still available.

* `Kate` deps to tags and bump RT version

* Keep unstable fmt

* Coverage support on stable compiler

* Update `Kate/v0.2.1`

* Header Forward Compatibility (#99)

* Use new versioned header extensions
* Data Root without hardcode decoding

* Fix header format for avail-subxt.

* Use `subxt-cli` to generate `api_dev.rs`

* New E2E tool: Run examples using an avail-node

* Add `README.md`

* Miguel/ava 405 rpc not working with scripts (#102)

* Use custom branch

* Use header extensions

* Fix fmt

* Data Root without hardcode decoding

* Use `avail-core` tag

* Bump `avail-core` dep

* Comment from codereview

* RPC minor fixes

* Use temporay branch for `avail-core`

* RPC `query_data_proof` uses runtime extractor

* Rollback to tagged `avail-core` & disable VTest

* Update `avail-core` deps

* Fix `BlockLength` decodification bug

* Data Proof RPC uses block instead runtime

* Fix header format for avail-subxt. (#103)

* Fix some merge issues

* Update `avail-subxt` doc

* Add decoding support to Extrinsics

* Bump some version

* Increase Epoch to 1h (#108)

* Uses the right version of `subxt` (#109)

* Empty-Commit

* Js script header changes  (#112)

* api file addition

(cherry picked from commit 921616f)

* empty comit

* Minor fixes for non-JS users

Co-authored-by: miguelDD1 <[email protected]>

Co-authored-by: Luke Tchang <[email protected]>
Co-authored-by: Miguel <[email protected]>
Co-authored-by: Kailas <[email protected]>
Co-authored-by: Luka Borkovic <[email protected]>
Co-authored-by: luka-ethernal <[email protected]>
MiguelDD1 added a commit that referenced this pull request Nov 18, 2022
* Release 1.3.0 (#111)

* Use substrate v0.9.29 - Partial

* Revert "Bump Runtime and Node versions (#88)"

This reverts commit 86af7d1.

* Revert "Use substrate v0.9.29 - Partial"

This reverts commit 58d4a96.

* Add nomad v1 pallets (#84)

* add nomad primitives

* patch dependencies to fix build issues

* remove tiny keccak from merkle

* add tiny keccak back to merkle and use to avoid extra allocation in left/right hash

* port nomad pallets, build failing

* add node and runtime changes

* add subxt changes

* fix compact block header and add specs to node for genesis info

* add new script for submitting data and header

* rename enqueue_data_root to dispatch_data_root

* rebase on primitive changes and change da-bridge message and TypedMessage to use BoundedVec

* fix failing home test after max message len change

* rebase on merged primitives

* remove unnecessary methods and add da-bridge docs

* update metadata and have home tree put default

* make da-bridge message type struct-based not vector-based

* remove panic in da bridge message

* remove finalized block hash mapping

* fix vec dependency after rebase on post-primitives PR

* make non body length public for tests

* Safety review

* Add benchmarks to `Nomad-home`

* Code review changes

  - New Benchmarks for `nomad/da-bridge`
  - Add header hash to `try_dispatch_data_root`.
  - Add assertions to `verify` section in benchmarks.

* Update `avail-subxt` examples

* Full header is needed

* Fmt fix

* fix double import and missing let after rebase

* fix subxt scripts with new da-bridge header metadata

* fix home update pallet weight

Co-authored-by: Miguel <[email protected]>
Co-authored-by: miguelDD1 <[email protected]>

* release change

* Miguel/ava 141 hard fork on plonk update 3 (#96)

* Header builder can use `Kate 0.1.0` and `0.2.0`

    - `Kate` & `da-primitives` have been moved out to another repo.
    - New version of `header_builder::build` which uses `Kate 0.2.0`.
      Version 1 is still available.

* `Kate` deps to tags and bump RT version

* Keep unstable fmt

* Add 1.64 toolchain to git workflow

* Coverage support on stable compiler

* Header builder can use `Kate 0.1.0` and `0.2.0`

    - `Kate` & `da-primitives` have been moved out to another repo.
    - New version of `header_builder::build` which uses `Kate 0.2.0`.
      Version 1 is still available.

* `Kate` deps to tags and bump RT version

* Keep unstable fmt

* Add 1.64 toolchain to git workflow

* Coverage support on stable compiler

* Header builder can use `Kate 0.1.0` and `0.2.0`

    - `Kate` & `da-primitives` have been moved out to another repo.
    - New version of `header_builder::build` which uses `Kate 0.2.0`.
      Version 1 is still available.

* `Kate` deps to tags and bump RT version

* Keep unstable fmt

* Coverage support on stable compiler

* Update `Kate/v0.2.1`

* Header Forward Compatibility (#99)

* Use new versioned header extensions
* Data Root without hardcode decoding

* Fix header format for avail-subxt.

* Miguel/ava 405 rpc not working with scripts (#102)

* Use custom branch

* Use header extensions

* Fix fmt

* Data Root without hardcode decoding

* Use `avail-core` tag

* Bump `avail-core` dep

* Comment from codereview

* RPC minor fixes

* Use temporay branch for `avail-core`

* RPC `query_data_proof` uses runtime extractor

* Rollback to tagged `avail-core` & disable VTest

* Update `avail-core` deps

* Fix `BlockLength` decodification bug

* Data Proof RPC uses block instead runtime

* Fix header format for avail-subxt. (#103)

* Use `subxt-cli` to generate `api_dev.rs`

* New E2E tool: Run examples using an avail-node

* Add `README.md`

* Fix some merge issues

* Update `avail-subxt` doc

* Add decoding support to Extrinsics

* Bump some version

* Increase Epoch to 1h (#108)

* Uses the right version of `subxt` (#109)

* Empty-Commit

* Use substrate v0.9.29 - Partial

* Revert "Bump Runtime and Node versions (#88)"

This reverts commit 86af7d1.

* Revert "Use substrate v0.9.29 - Partial"

This reverts commit 58d4a96.

* Add nomad v1 pallets (#84)

* add nomad primitives

* patch dependencies to fix build issues

* remove tiny keccak from merkle

* add tiny keccak back to merkle and use to avoid extra allocation in left/right hash

* port nomad pallets, build failing

* add node and runtime changes

* add subxt changes

* fix compact block header and add specs to node for genesis info

* add new script for submitting data and header

* rename enqueue_data_root to dispatch_data_root

* rebase on primitive changes and change da-bridge message and TypedMessage to use BoundedVec

* fix failing home test after max message len change

* rebase on merged primitives

* remove unnecessary methods and add da-bridge docs

* update metadata and have home tree put default

* make da-bridge message type struct-based not vector-based

* remove panic in da bridge message

* remove finalized block hash mapping

* fix vec dependency after rebase on post-primitives PR

* make non body length public for tests

* Safety review

* Add benchmarks to `Nomad-home`

* Code review changes

  - New Benchmarks for `nomad/da-bridge`
  - Add header hash to `try_dispatch_data_root`.
  - Add assertions to `verify` section in benchmarks.

* Update `avail-subxt` examples

* Full header is needed

* Fmt fix

* fix double import and missing let after rebase

* fix subxt scripts with new da-bridge header metadata

* fix home update pallet weight

Co-authored-by: Miguel <[email protected]>
Co-authored-by: miguelDD1 <[email protected]>

* release change

* Miguel/ava 141 hard fork on plonk update 3 (#96)

* Header builder can use `Kate 0.1.0` and `0.2.0`

    - `Kate` & `da-primitives` have been moved out to another repo.
    - New version of `header_builder::build` which uses `Kate 0.2.0`.
      Version 1 is still available.

* `Kate` deps to tags and bump RT version

* Keep unstable fmt

* Add 1.64 toolchain to git workflow

* Coverage support on stable compiler

* Header builder can use `Kate 0.1.0` and `0.2.0`

    - `Kate` & `da-primitives` have been moved out to another repo.
    - New version of `header_builder::build` which uses `Kate 0.2.0`.
      Version 1 is still available.

* `Kate` deps to tags and bump RT version

* Keep unstable fmt

* Add 1.64 toolchain to git workflow

* Coverage support on stable compiler

* Header builder can use `Kate 0.1.0` and `0.2.0`

    - `Kate` & `da-primitives` have been moved out to another repo.
    - New version of `header_builder::build` which uses `Kate 0.2.0`.
      Version 1 is still available.

* `Kate` deps to tags and bump RT version

* Keep unstable fmt

* Coverage support on stable compiler

* Update `Kate/v0.2.1`

* Header Forward Compatibility (#99)

* Use new versioned header extensions
* Data Root without hardcode decoding

* Fix header format for avail-subxt.

* Use `subxt-cli` to generate `api_dev.rs`

* New E2E tool: Run examples using an avail-node

* Add `README.md`

* Miguel/ava 405 rpc not working with scripts (#102)

* Use custom branch

* Use header extensions

* Fix fmt

* Data Root without hardcode decoding

* Use `avail-core` tag

* Bump `avail-core` dep

* Comment from codereview

* RPC minor fixes

* Use temporay branch for `avail-core`

* RPC `query_data_proof` uses runtime extractor

* Rollback to tagged `avail-core` & disable VTest

* Update `avail-core` deps

* Fix `BlockLength` decodification bug

* Data Proof RPC uses block instead runtime

* Fix header format for avail-subxt. (#103)

* Fix some merge issues

* Update `avail-subxt` doc

* Add decoding support to Extrinsics

* Bump some version

* Increase Epoch to 1h (#108)

* Uses the right version of `subxt` (#109)

* Empty-Commit

* Js script header changes  (#112)

* api file addition

(cherry picked from commit 921616f)

* empty comit

* Minor fixes for non-JS users

Co-authored-by: miguelDD1 <[email protected]>

Co-authored-by: Luke Tchang <[email protected]>
Co-authored-by: Miguel <[email protected]>
Co-authored-by: Kailas <[email protected]>
Co-authored-by: Luka Borkovic <[email protected]>
Co-authored-by: luka-ethernal <[email protected]>

* ops(ci): Switching to nightly rust for build

* ops(security): Adding Security CI Files

* fix: adding wasm32

* fix: switching wasm32 to nightly as well

* Add RPC for app data rows fetching.

* Disable security workflow.

* Update versions.

Co-authored-by: Luke Tchang <[email protected]>
Co-authored-by: Miguel <[email protected]>
Co-authored-by: Kailas <[email protected]>
Co-authored-by: Luka Borkovic <[email protected]>
Co-authored-by: luka-ethernal <[email protected]>
Co-authored-by: John Hilliard <[email protected]>
Co-authored-by: Aleksandar Terentić <[email protected]>
Co-authored-by: aterentic-ethernal <[email protected]>
umadayal pushed a commit to succinctlabs/avail-core that referenced this pull request Oct 31, 2024
…udit/hal_02

ChunkSize as Constant and some checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants