Miguel/ava 141 hard fork on plonk update #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `Kate` & `da-primitives` have been moved out to another repo.
- New version of `header_builder::build` which uses `Kate 0.2.0`.
Version 1 is still available.
AVA-141 Hard Fork on Plonk update
Update our Acceptance Criteria:
|
* add nomad primitives * patch dependencies to fix build issues * remove tiny keccak from merkle * add tiny keccak back to merkle and use to avoid extra allocation in left/right hash * port nomad pallets, build failing * add node and runtime changes * add subxt changes * fix compact block header and add specs to node for genesis info * add new script for submitting data and header * rename enqueue_data_root to dispatch_data_root * rebase on primitive changes and change da-bridge message and TypedMessage to use BoundedVec * fix failing home test after max message len change * rebase on merged primitives * remove unnecessary methods and add da-bridge docs * update metadata and have home tree put default * make da-bridge message type struct-based not vector-based * remove panic in da bridge message * remove finalized block hash mapping * fix vec dependency after rebase on post-primitives PR * make non body length public for tests * Safety review * Add benchmarks to `Nomad-home` * Code review changes - New Benchmarks for `nomad/da-bridge` - Add header hash to `try_dispatch_data_root`. - Add assertions to `verify` section in benchmarks. * Update `avail-subxt` examples * Full header is needed * Fmt fix * fix double import and missing let after rebase * fix subxt scripts with new da-bridge header metadata * fix home update pallet weight Co-authored-by: Miguel <[email protected]> Co-authored-by: miguelDD1 <[email protected]>
- `Kate` & `da-primitives` have been moved out to another repo.
- New version of `header_builder::build` which uses `Kate 0.2.0`.
Version 1 is still available.
…-miguelDD1:maticnetwork/avail into miguel/ava-141-hard-fork-on-plonk-update
Codecov ReportBase: 52.87% // Head: 50.80% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #94 +/- ##
===========================================
- Coverage 52.87% 50.80% -2.08%
===========================================
Files 65 50 -15
Lines 12539 9035 -3504
===========================================
- Hits 6630 4590 -2040
+ Misses 5909 4445 -1464
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
- `Kate` & `da-primitives` have been moved out to another repo.
- New version of `header_builder::build` which uses `Kate 0.2.0`.
Version 1 is still available.
…-miguelDD1:maticnetwork/avail into miguel/ava-141-hard-fork-on-plonk-update
|
Superseeded by PR#96 |
|
Super-seeded by #96 |
umadayal
pushed a commit
to succinctlabs/avail-core
that referenced
this pull request
Oct 31, 2024
…dk-bump-5 Polkadot sdk bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plonk updates from 0.8.2 to 0.12.0
This hard-fork upgrade adds a new version of hosted function
header_builder_build. The new version useskate-0.2.0which depends ondusk-plonk-0.12.0.Primitives & Kate moved to
avail-corerepoWe moved these crates into the external repo
avail-core. That facilitates the use of several versions ofKate. Particularly we are using:Kate:0.1.0on runtime with spec version == 4.Kate:0.2.0on runtime with spec version == 5.