Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate handler/jsonrpc logic to async flavor #70

Open
hexfusion opened this issue Oct 12, 2022 · 2 comments
Open

migrate handler/jsonrpc logic to async flavor #70

hexfusion opened this issue Oct 12, 2022 · 2 comments
Assignees

Comments

@hexfusion
Copy link
Contributor

hexfusion commented Oct 12, 2022

During testing it has become obvious paritytech/jsonrpc[1] is not well suited for async muti threaded code. This issue is around moving the current handler logic and API to actix or strait hyper[2] or other alternative,[3].

[1] paritytech/jsonrpc#485
[2] https://docs.rs/actix-web/latest/actix_web/web/struct.Data.html
[3] https://github.com/paritytech/jsonrpsee/

@hexfusion hexfusion added this to the [email protected] milestone Oct 12, 2022
@hexfusion hexfusion self-assigned this Oct 12, 2022
@hexfusion hexfusion changed the title migrate handler/jsonrpc logic to actix migrate handler/jsonrpc logic to actix/hyper Oct 12, 2022
@hexfusion
Copy link
Contributor Author

actix proved to cause a lot of dependency issues so for now going to try and improve existing setup.

@hexfusion hexfusion changed the title migrate handler/jsonrpc logic to actix/hyper migrate handler/jsonrpc logic to async flavor Oct 12, 2022
@hexfusion
Copy link
Contributor Author

hexfusion commented Nov 14, 2022

Played with a full hyper impl and it feels much better to be honest. I think we will need this to ever support websockets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant