Update avago 1.12.0 initial poc.9 #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansuvak
requested review from
richardpringle,
geoff-vball,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
cam-schultz
approved these changes
Nov 15, 2024
geoff-vball
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Updates avago to 1.12.0 initial poc.9 to keep up with the interface changes
How this works
all changes are straightforward except for the addition of required
GetCurrentValidatorSetto pchain state interface. Implemented as no-op as it's not compatible with existing interface which requires full length IDs (ids.ID) instead of short onesids.NodeIDHow this was tested
tests should pass
How is this documented