Create default registry at runtime #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
requested review from
iansuvak,
geoff-vball,
bernard-avalabs and
michaelkaplan13
michaelkaplan13
approved these changes
Oct 10, 2024
iansuvak
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
We currently use
prometheus.DefaultRegistereras the registerer for metrics we don't intend to collect.DefaultRegisterersimply callsNewRegistry()at compile time. In situations that createNewSignatureAggregators within the same application instance (such as Ginkgo test suites), this can cause the aggregator to fail withAlreadyRegisteredError.How this works
Replaces
DefaultRegistererwithNewRegistry()so that the no-op registry is created at runtime rather than compile time.How this was tested
CI
How is this documented
N/A