Retry fetch logs #317
Merged
Retry fetch logs #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
requested review from
michaelkaplan13,
minghinmatthewlam,
geoff-vball and
bernard-avalabs
as code owners
geoff-vball
reviewed
Jun 4, 2024
michaelkaplan13
previously approved these changes
Jun 4, 2024
minghinmatthewlam
previously approved these changes
Jun 5, 2024
geoff-vball
previously approved these changes
Jun 5, 2024
cam-schultz
dismissed stale reviews from geoff-vball, minghinmatthewlam, and michaelkaplan13
via
5cffb2e
cam-schultz
requested review from
michaelkaplan13,
minghinmatthewlam and
geoff-vball
|
I also added a goreleaser change to not mark rc's as |
michaelkaplan13
approved these changes
Jun 5, 2024
bernard-avalabs
approved these changes
Jun 5, 2024
| return logs, nil | ||
| } | ||
| if i != numRetries-1 { | ||
| time.Sleep(retryInterval) |
There was a problem hiding this comment.
We may want to consider some type of exponential back off between retries if the height difference between nodes can potentially be significant.
There was a problem hiding this comment.
As part of the nonce ordering fix, I'm going to implement a generic retry helper, and will consider adding exponential backoffs there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The websocket connection serving new blocks to process and the RPC request to fetch logs from a block containing Warp messages may be served by different nodes that have indexed different heights. If the node serving the RPC request is behind the node serving blocks, then the
FilterLogscall will fail. Adding retries the theFilterLogsRPC request works around this.How this works
See above
How this was tested
CI
How is this documented
N/A