Rpc options #278
Merged
Rpc options #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
najeal
requested review from
michaelkaplan13,
cam-schultz,
minghinmatthewlam,
geoff-vball and
bernard-avalabs
as code owners
cam-schultz
reviewed
May 5, 2024
config/test_utils.go
Outdated
| @@ -1,5 +1,3 @@ | |||
| //go:build testing | |||
There was a problem hiding this comment.
Please keep this tag in this file. This file is only used in unit tests, so we use the tag to exclude this file from release builds.
change http into HTTP Co-authored-by: cam-schultz <[email protected]> Signed-off-by: nathan haim <[email protected]>
1 task
cam-schultz
previously approved these changes
May 6, 2024
geoff-vball
previously approved these changes
May 6, 2024
|
@michaelkaplan13 it looks like you forgot the suggestion 🙂 |
config/config.go
Outdated
| @@ -126,6 +126,7 @@ type WarpQuorum struct { | |||
| type APIConfig struct { | |||
| BaseURL string `mapstructure:"base-url" json:"base-url"` | |||
| QueryParams map[string]string `mapstructure:"query-parameters" json:"query-parameters"` | |||
| HttpHeaders map[string]string `mapstructure:"http-headers" json:"http-headers"` | |||
There was a problem hiding this comment.
Following golang capitalization conventions, lets make this HTTPHeaders.
My bad! forgot to hit submit |
geoff-vball
approved these changes
May 6, 2024
michaelkaplan13
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adding http-headers for p-chain and info-api clients.
Related to #186
How this works
Use mechanism introduced in #268 to pass http-headers to p-chain & info-api clients.
How this was tested
How is this documented
Details of the new Config fields are added in the README.