Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support address allow/deny lists on source subnet #79

Closed
Tracked by #242
cam-schultz opened this issue Nov 3, 2023 · 3 comments · Fixed by #245
Closed
Tracked by #242

Support address allow/deny lists on source subnet #79

cam-schultz opened this issue Nov 3, 2023 · 3 comments · Fixed by #245
Assignees
Labels
enhancement New feature or request

Comments

@cam-schultz
Copy link
Collaborator

cam-schultz commented Nov 3, 2023

Context and scope
Relayers are configurable to relay Warp messages created via different messaging protocols, e.g. Teleporter. However, relayer operators may wish to only relay messages sent by a specific set of addresses, for instance if they want to tie relayer gas expenditure due to message delivery to transactions initiated by known addresses. Relayers may also be liable for compliance violations if they deliver messages sent by a sanctioned address.

We should add configuration options on the sending subnet to allow relayers to apply filters at the address level.

Open Questions

  • The contract that calls the warp precompile to send the message is the address listed in the Warp AddressedCall payload type. For example, this is the TeleporterMessenger contract address for Teleporter messages. How would we get the original transaction sender in the relayer? Is that included in the message logs/receipt?
  • There are two addresses to consider: the EOA that initiates the transaction on the source blockchain, and the address that calls Teleporter (or another messaging protocol). It makes sense to filter on both, but they may need to be treated differently.
@cam-schultz cam-schultz added the enhancement New feature or request label Nov 3, 2023
@cam-schultz cam-schultz changed the title Support address allow lists on source subnet Support address allow/deny lists on source subnet Nov 3, 2023
@Nuttymoon
Copy link
Contributor

Nuttymoon commented Mar 15, 2024

Hi, is there a timeline for this issue? This is a hard requirement to go to mainnet IMO.

@cam-schultz cam-schultz added this to the Post-Durango fast follows milestone Mar 15, 2024
@cam-schultz
Copy link
Collaborator Author

Added to the current milestone. Agreed this is a feature we should implement soon.

@cam-schultz
Copy link
Collaborator Author

It will most likely make the most sense to implement #80 alongside this, as the source and destination addresses take on a different role with #240

@cam-schultz cam-schultz moved this from Backlog 🗄️ to In Progress 🏗 in Platform Engineering Group Mar 20, 2024
@cam-schultz cam-schultz self-assigned this Mar 20, 2024
@github-project-automation github-project-automation bot moved this from In Progress 🏗 to Done ✅ in Platform Engineering Group Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants