Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppRequestNetwork unit tests #237

Open
cam-schultz opened this issue Mar 15, 2024 · 1 comment
Open

Add AppRequestNetwork unit tests #237

cam-schultz opened this issue Mar 15, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@cam-schultz
Copy link
Collaborator

Context and scope
AppRequestNetwork is a wrapper around the AvalancheGo TestNetwork construct, which facilitates non-node peer-to-peer connections with validators. The wrapper has gotten more complex, as we've added support for earlier peer validation and manual peer connection. We should add unit tests to support this type.

Discussion and alternatives
In order to write unit tests, we'll need mocks for:

Open questions
What's the best way to mock interfaces from external packages? An AvalancheGo PR may be necessary.

@najeal
Copy link
Contributor

najeal commented Apr 24, 2024

A good tool to mock interfaces from external packages: https://vektra.github.io/mockery/latest/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog 🗄️
Development

No branches or pull requests

2 participants