Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize packing subnetConversionData for initialValidatorSet #559

Open
iansuvak opened this issue Sep 18, 2024 · 0 comments
Open

Optimize packing subnetConversionData for initialValidatorSet #559

iansuvak opened this issue Sep 18, 2024 · 0 comments
Labels

Comments

@iansuvak
Copy link
Contributor

Context and scope
#547 is merged but the subnetConversionData packing is created by recursively calling abi.encodePacked on the already packed data for each iteration over the initialValidators array. We should make it allocate the data once and copy packed initial validator data into it instead of allocating a new growing bytes array on each iteration

Discussion and alternatives
Open questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog 🗄️
Development

No branches or pull requests

1 participant