Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate ReentrancyGuard initialization #465

Open
minghinmatthewlam opened this issue Jul 30, 2024 · 0 comments
Open

Investigate ReentrancyGuard initialization #465

minghinmatthewlam opened this issue Jul 30, 2024 · 0 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@minghinmatthewlam
Copy link

Context and scope
Right now in the ReentrancyGuards that Teleporter messenger uses, there are state variables initialized in the constructor of the contract. If the Teleporter deploy tx fails, then the work around as discussed in this bug is to use a state upgrade, and the state upgrade would also need to set the specific values for _sendEntered and _receiveEntered storage slots. We can look at moving that logic outside of the constructor so that we don't need to set the value for specific storage slots, or should at least have documentation for these steps.

Discussion and alternatives
Look at alternative to setting reentrancy state variable initial values than from setting in constructor. At least document steps to set storage slot upgrades.

Related to #306

@minghinmatthewlam minghinmatthewlam added bug Something isn't working documentation Improvements or additions to documentation labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
Status: Backlog 🗄️
Development

No branches or pull requests

1 participant