Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for necessary dependencies in build-script #1213

Open
richardpringle opened this issue Jul 29, 2024 · 1 comment
Open

Check for necessary dependencies in build-script #1213

richardpringle opened this issue Jul 29, 2024 · 1 comment

Comments

@richardpringle
Copy link
Contributor

There might be a better way to do this, but currently, all programs require borsh as a dependency and if they use state, they require bytemuck. If you don't supply either of those dependencies, the error messages from the compiler aren't super intuitive. I'm proposing that we do a check in the build-script.

@richardpringle
Copy link
Contributor Author

Turns out I found a way to solve this. I can either derive Zeroable and Pod, instead of NoUninit... or bytemuck can accept my PR:
Lokathor/bytemuck#259

I think them accepting my PR is the cleaner solution as I don't think we need to be as strict as Pod and Zeroable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant