Update to latest p2p API #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
joshua-kim
commented
Jul 2, 2024
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
darioush
approved these changes
Jul 2, 2024
oxbee
pushed a commit
to taurusgroup/coreth
that referenced
this pull request
Nov 6, 2024
* sdk app errors Signed-off-by: Joshua Kim <[email protected]> * nit Signed-off-by: Joshua Kim <[email protected]> * nit Signed-off-by: Joshua Kim <[email protected]> * nit Signed-off-by: Joshua Kim <[email protected]> * nit Signed-off-by: Joshua Kim <[email protected]> * nit Signed-off-by: Joshua Kim <[email protected]> * nit Signed-off-by: Joshua Kim <[email protected]> * nit Signed-off-by: Joshua Kim <[email protected]> * nti Signed-off-by: Joshua Kim <[email protected]> * nit Signed-off-by: Joshua Kim <[email protected]> * nit Signed-off-by: Joshua Kim <[email protected]> * nit Signed-off-by: Joshua Kim <[email protected]> * nti Signed-off-by: Joshua Kim <[email protected]> --------- Signed-off-by: Joshua Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Updates to ava-labs/avalanchego#2753 version of the p2p API which adds a feature to respond with application-defined errors. This is needed as part of the interface update.
How this works
Updates interface signatures
How this was tested
CI