Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Stakers handling in P-chain state #2512

Closed
abi87 opened this issue Dec 19, 2023 · 1 comment · Fixed by #2505
Closed

Simplify Stakers handling in P-chain state #2512

abi87 opened this issue Dec 19, 2023 · 1 comment · Fixed by #2505
Assignees
@abi87
Labels
cleanup Code quality improvement lifecycle/stale

Comments

@abi87
Copy link
Contributor

abi87 commented Dec 19, 2023

In the platformvm, whenever a staker is added or removed a whole bunch of structures needs to be updated.
This is currently carried out in a monster method called writeCurrentStakers.
While this implementation may be the most efficient, it does keep implicit a whole bunch of dependencies among stakers data.
We should simplify the stakers handling and make dependencies explicit.
@abi87 abi87 added the cleanup Code quality improvement label Dec 19, 2023
@abi87 abi87 self-assigned this Dec 19, 2023
This was linked to pull requests Dec 19, 2023
Pull apart writeCurrentStakers method - Part 1 #2074
Closed
Pull apart writeCurrentStakers method - Part 2 #2079
Closed
Pull apart writeCurrentStakers method - Part 3 #2086
Closed
P-chain Add UTs around stakers persistence in platformvm state #2505
Merged
@abi87 abi87 mentioned this issue Dec 19, 2023
Merged
@abi87 abi87 moved this from Backlog 🗄️ to In Review 👀 in Platform Engineering Group Dec 19, 2023
@github-actions GitHub Actions
Copy link

This issue has become stale because it has been open 60 days with no activity. Adding the lifecycle/frozen label will cause this issue to ignore lifecycle events.

@abi87 abi87 closed this as completed Mar 6, 2024
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in Platform Engineering Group Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abi87 abi87

Labels
cleanup Code quality improvement lifecycle/stale
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
1 participant
@abi87