Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Environment Variables when avalanchego-path or plugin-dir are not provided #605

Closed
martineckardt opened this issue Jul 20, 2023 · 0 comments · Fixed by #603
Closed
Assignees

Comments

@martineckardt
Copy link
Collaborator

Problem
On the command line it is easy to use the environment variables:

  avalanche-network-runner control start \
  --log-level debug \
  --endpoint="0.0.0.0:8080" \
  --number-of-nodes=5 \
  --avalanchego-path ${AVALANCHEGO_EXEC_PATH} \
  --plugin-dir ${AVALANCHEGO_PLUGIN_PATH} \
  --blockchain-specs '[{"vm_name": "subnetevm", "genesis": "./tests/precompile/genesis/evm-configuration-genesis.json"}]'

Unfortunately, that does not work with HTTP clients, such as Postman or ThunderClient. Therefore, we have to enter the paths in the HTTP Clients.

Possible solution
Is it possible to make execPath and pluginDir optional parameters in the control/start endpoint?
If they are not provided, then ANR should just use the contents of the environment variables AVALANCHEGO_EXEC_PATH and AVALANCHEGO_PLUGIN_PATH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants