New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take BlockNumber as a JSON number in subspace gateway HTTP #3323

Open

teor2345 opened this issue Dec 18, 2024 · 0 comments

Contributor

teor2345 commented Dec 18, 2024 •

edited

Loading

This looks like a bug to me. Why would you want to receive a number as a string in JSON instead of an actual number? This should be a number, just like all the others in this very struct.

Originally posted by @nazar-pc in #3286 (comment)

This requires a change to both the subspace gateway and the mapping indexer service.

At the same time, we could also:

add a version enum to the mapping struct
take multiple mappings at a time (allows us to batch piece fetches)

like we do for the RPC server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment