Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for direnv to second line #53

Merged
merged 7 commits into from
Jun 18, 2020

Conversation

patrickserrano
Copy link
Contributor

Add support for displaying the current directory's Python virtual environment when direnv and pyenv are installed and being used.

image

@sjk07
Copy link
Member

sjk07 commented Jun 4, 2020

@patrickserrano cool! does this also work in sh?

also I don't use python but is this all the information that would be required for a user to understand what virtual env they are looking in and is there a better way to format the text?

ex (env-name python-version)

finally, could you add some description to the readme

@patrickserrano
Copy link
Contributor Author

@sjk07 the name of the virtualenv shown in the prompt is name the user set when during virtualenv configuration + -<python version>. I think that's enough information to understand what they're looking at.

So in my screenshot the name of the virtualenv is virtual-env-test and it's using Python 3.6.5 which is how you get virtual-env-test-3.6.5. But when working on airflow the name that's displayed is airflow-3.6.5.

As for sh support, do the interactive features of prompt work with sh? I don't use it, but when I switched to sh and sourced the profile, it said I was using prompt but I only had a single line prompt with none of the features I'd get in bash or zsh. I also don't see in where in src/sh/profile we would be setting the prompt display.

Also, updated readme.

Copy link
Member

@sjk07 sjk07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kewl Stuff

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/zsh/scripts/eval/set-prompt Outdated Show resolved Hide resolved
src/bash/scripts/eval/set-prompt Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@sjk07 sjk07 merged commit 8dbaa0e into automotiveMastermind:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants