Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix publishing for release #38

Merged
merged 1 commit into from
Dec 18, 2019
Merged

build: fix publishing for release #38

merged 1 commit into from
Dec 18, 2019

Conversation

dmccaffery
Copy link
Member

@dmccaffery dmccaffery commented Dec 18, 2019 •
edited
Loading

Closes: #35

@dmccaffery dmccaffery changed the title fix-publish build: fix publishing for release Dec 18, 2019
@dmccaffery dmccaffery requested a review from sjk07 December 18, 2019 22:28
@dmccaffery dmccaffery added the bug label Dec 18, 2019
@dmccaffery dmccaffery self-assigned this Dec 18, 2019
sjk07
sjk07 approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@sjk07 sjk07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the set error?

@dmccaffery
Copy link
Member Author

yes; there is variance between versions of git and whether or not --set exists -- I eliminated the need for setting the user.name and user.email in the first place.

@dmccaffery dmccaffery merged commit b7a33b0 into automotiveMastermind:master Dec 18, 2019
@dmccaffery dmccaffery deleted the fix-publish branch December 18, 2019 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjk07 sjk07 sjk07 approved these changes

Assignees

@dmccaffery dmccaffery

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

master build has failed
2 participants
@dmccaffery @sjk07