Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: move to circle ci #24

Merged
merged 2 commits into from
Jun 26, 2019
Merged

build: move to circle ci #24

merged 2 commits into from
Jun 26, 2019

Conversation

dmccaffery
Copy link
Member

@dmccaffery dmccaffery commented Jun 26, 2019

  • migrate to circleci for automated build and deployment
  • execute prompt install and a single prompt command to smoke screen the installation:
    • macos
    • ubuntu
    • fedora 29/30
    • debian
    • centos
    • mint
  • update readme to include thank you to circleci and a build status

Closes: #23

@dmccaffery dmccaffery requested a review from sjk07 as a code owner June 26, 2019 04:46
@dmccaffery
Copy link
Member Author

@sjk07 : added smoke test for all supported platforms if I can get your review?

@dmccaffery dmccaffery self-assigned this Jun 26, 2019
Copy link
Member

@sjk07 sjk07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saw this b4 and the builds didn't pass yet, but looks like we are are good now.

LGTM! :shipit:

@dmccaffery
Copy link
Member Author

yeah; @sjk07 : I had to create custom docker files to install the bare minimum prerequisites on each of the platforms, namely sudo and locales. In addition, brew refuses to install as root, so I needed to add a custom user and add it to sudoers without a password requirement in order to get this to run within docker. Its as close to real-world as I can get.

@dmccaffery dmccaffery merged commit 0b09959 into automotiveMastermind:master Jun 26, 2019
@dmccaffery dmccaffery deleted the circle-ci branch June 26, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add tests for *nix distros
2 participants