Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dotnet): set paths for global tools #19

Merged
merged 1 commit into from
Jun 26, 2019
Merged

fix(dotnet): set paths for global tools #19

merged 1 commit into from
Jun 26, 2019

Conversation

dmccaffery
Copy link
Member

No description provided.

@dmccaffery dmccaffery added the bug label Jun 25, 2019
@dmccaffery dmccaffery self-assigned this Jun 25, 2019
@dmccaffery
Copy link
Member Author

@sjk07 @tim528 @tiffanywang3 : can I get a review?

@sjk07
Copy link
Member

sjk07 commented Jun 25, 2019

@dmccaffery just for my own sanity what caused this change?

We are checking if dotnet is in use/local/share/... Then set it. If it's in $home/.dotnet then export the dotnet root env var.

We also always default to the home directory dotnet install if it exists.

PS: Push your storage branch 😘

@tim528
Copy link
Member

tim528 commented Jun 25, 2019

Reviewed good sir, and I give you my stamp of approval

@dmccaffery
Copy link
Member Author

@sjk07 : DOTNET_ROOT is used for the new(ish) global tools dependency evaluation, for instance:

dotnet tool install -g dotnetsay

We did not include this on the PATH previously, so global tools would fail. The reason to check for /usr/local/share/dotnet is in case someone installs the dotnet runtime as a shared runtime (apt-get, etc). We also evaluate $HOME/.dotnet as this is where our own installation places the runtime.

@dmccaffery dmccaffery merged commit d16a5f2 into automotiveMastermind:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants