Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently unidentified bug in fs_store.rs::compact that results in data loss. #52

Open
issackelly opened this issue Sep 15, 2023 · 3 comments

Comments

@issackelly
Copy link
Contributor

No description provided.

@issackelly
Copy link
Contributor Author

Occasionally, if i make a few dozen changes to my document... this branch is called:

84ad6cf#diff-05a5db13701065ba8c66d1545cd83b1ba2b610cd217f6ecf94b6fda757864f28R183-R186

I haven't yet identified why.

@issackelly
Copy link
Contributor Author

In repo.rs compaction is an optional step that occurs at time of save. and in fs_store.rs compaction is a step that happens independent of what is going on.

I think in alex's implementation it assumes that the live path will only ever run append and something else will run compact (but never incremental).

The InMemoryStore tells a very different story, and it is replacing the contents.

This commit rectifies that I think 9fdc4cd

@gterzian
Copy link
Collaborator

cc @alexjg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants