Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Buffer.from instead of new Buffer #413

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Using Buffer.from instead of new Buffer #413

merged 1 commit into from
Aug 16, 2018

Conversation

fishcharlie
Copy link
Member

Summary:

Using Buffer.from instead of new Buffer due to new Node.js DeprecationWarning.

Type (select 1):

  • Bug fix
  • Feature implementation
  • Documentation improvement
  • Testing improvement
  • Test added to report bug (GitHub issue #--- @---)
  • Something not listed here: Codebase improvements

Is this a breaking change? (select 1):

  • 🚨 YES 🚨: Acceptable due to Dynamoose requiring new Node.js versions
  • No
  • I'm not sure

Is this ready to be merged into Dynamoose? (select 1):

  • Yes
  • No

Are all the tests currently passing on this PR? (select 1):

  • Yes
  • No

Other:

  • I have searched through the GitHub pull requests to ensure this PR has not already been submitted
  • I have updated the Dynamoose documentation (if required) given the changes I made
  • I have added/updated the Dynamoose test cases (if required) given the changes I made
  • I have run npm test from the root of the project directory to ensure all tests continue to pass
  • I agree that all changes made in this pull request may be distributed and are made available in accordance with the Dynamoose license
  • All of my commits and commit messages are detailed, explain what changes were made, and are easy to follow and understand
  • I have confirmed that all my code changes are indented properly using 2 spaces
  • I have filled out all fields above

@coveralls
Copy link

Pull Request Test Coverage Report for Build 606

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.049%

Totals Coverage Status
Change from base Build 605: 0.0%
Covered Lines: 1850
Relevant Lines: 2129

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Aug 16, 2018

Pull Request Test Coverage Report for Build 606

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.049%

Totals Coverage Status
Change from base Build 605: 0.0%
Covered Lines: 1850
Relevant Lines: 2129

💛 - Coveralls

@fishcharlie fishcharlie merged commit d05e004 into dynamoose:master Aug 16, 2018
@fishcharlie fishcharlie mentioned this pull request Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants