-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for specifying the ReturnValues option in update #350
added support for specifying the ReturnValues option in update #350
Conversation
@manast This looks amazing. Thanks so much!! Is there any chance you could add documentation regarding this new feature? We should also probably confirm to make sure there is a test to ensure backwards compatibility, and if not we should add one to confirm the backwards compatibility. We will try to get this in for version 0.9. Thanks again!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks again @manast! We'll get this in for version 0.9. |
Can we add a note to the documentation clearly stating that the Dynamoose default differs from the DynamoDB default? The current phrasing led me to believe that Also, what do you think about adding an option |
@dobrynin Both ideas sound great! PR would be awesome. |
Model.update
always returns all the new values in every call. This can have a severe performance penalty in some scenarios. This PR provides a backwards compatible optionreturnValues
when callingupdate
so that the 5 different settings provided by Dynamo can be used: