Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding updateTimestamps option to Model.save #317

Merged
merged 4 commits into from
Jun 13, 2018
Merged

Adding updateTimestamps option to Model.save #317

merged 4 commits into from
Jun 13, 2018

Conversation

fishcharlie
Copy link
Member

Closes #227

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 82.564% when pulling e9cfd58 on fishcharlie:limittimestampupdating into 8f5c192 on automategreen:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 82.564% when pulling e9cfd58 on fishcharlie:limittimestampupdating into 8f5c192 on automategreen:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 82.564% when pulling e9cfd58 on fishcharlie:limittimestampupdating into 8f5c192 on automategreen:master.

@coveralls
Copy link

coveralls commented Mar 17, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 82.408% when pulling 29456ac on fishcharlie:limittimestampupdating into 8f5c192 on automategreen:master.

@fishcharlie fishcharlie added this to the v0.9.0 milestone Mar 17, 2018
@fishcharlie fishcharlie mentioned this pull request Mar 23, 2018
Merged
@fishcharlie
Copy link
Member Author

This might be better to implement in plugins #325

@fishcharlie
Copy link
Member Author

I actually think this is useful to integrate into Dynamoose itself since timestamps are. If we ever move timestamps into a separate plugin then we can reconsider moving this PR into a separate plugin. But until then, let's move ahead with getting this PR in.

@fishcharlie fishcharlie mentioned this pull request Apr 3, 2018
Closed
@fishcharlie fishcharlie modified the milestones: v0.9.0, v1.0 Jun 13, 2018
@fishcharlie fishcharlie merged commit cb6476b into dynamoose:master Jun 13, 2018
@fishcharlie fishcharlie deleted the limittimestampupdating branch June 13, 2018 01:37
@fishcharlie fishcharlie mentioned this pull request Jun 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecwyne ecwyne ecwyne approved these changes

@brandongoode brandongoode Awaiting requested review from brandongoode

Assignees
No one assigned
Labels
type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fishcharlie @coveralls @ecwyne