We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I noticed this behaviour while implementing controlKit.
I have found a fix which involves changing:
if (!options.parentDomElementId) { node = new Node(); document.body.appendChild(node.getElement()); } else { node = Node.getNodeById(options.parentDomElementId); }
to
if (!options.parentDomElementId) { node = new Node(); document.body.appendChild(node.getElement()); } else { node = new Node(); document.getElementById(options.parentDomElementId).appendChild(node.getElement()); }
Ideally though, I would like it to be something more like this to allow a domElement to be passed rather than referenced by id
var rootElement = document.body; if (options.parentDomElement) { rootElement = options.parentDomElement } else if(options.parentDomElementId){ rootElement = document.getElementById(options.parentDomElementId) } node = new Node(); rootElement.appendChild(node.getElement());
I will make these changes in my own fork and will submit a PR if you would like to merge the changes.
The text was updated successfully, but these errors were encountered:
Allow mouse events to bubble to parent element
57f79fc
Add ability to pass domElement directly too.
No branches or pull requests
I noticed this behaviour while implementing controlKit.
I have found a fix which involves changing:
to
Ideally though, I would like it to be something more like this to allow a domElement to be passed rather than referenced by id
I will make these changes in my own fork and will submit a PR if you would like to merge the changes.
The text was updated successfully, but these errors were encountered: