Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for RTL messages #5

Open
dov opened this issue Feb 9, 2019 · 3 comments
Open

Add support for RTL messages #5

dov opened this issue Feb 9, 2019 · 3 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@dov
Copy link

dov commented Feb 9, 2019

Messages in RTL languages are not formatted correctly in the output. To correctly support RTL the following is needed:

  1. Recognize that the message is in RTL by recognizing that the first "strong" character (as defined by the unicode bidirectional algorithm) is a strong RTL character. (Other heuristics exists e.g. if a majority of characters in the message are RTL.)
  2. Add <span dir="RTL">...</span> around the message.
@automaciej
Copy link
Owner

Is there any chance you could help? Test data, or examples, would help. A piece of an RTL export. I have zero experience with RTL languages.

@automaciej
Copy link
Owner

@dov – could you show / paste / upload an example of an RTL export? I can't code it without test data.

@automaciej
Copy link
Owner

https://github.com/dsadinoff/whatsapp-archive seems to contain bidirectional text support. Unfortunately there are many other changes and I can't simply merge the bidirectional support into my code.

@automaciej automaciej added the help wanted Extra attention is needed label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants