Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CircleCI Partner Review #1

Closed
EricRibeiro opened this issue Jun 29, 2022 · 1 comment · Fixed by #2
Closed

CircleCI Partner Review #1

EricRibeiro opened this issue Jun 29, 2022 · 1 comment · Fixed by #2

Comments

@EricRibeiro
Copy link

Hello Autify team 👋

I am from the @circleci Community and Partner Engineering team, here to help with a review for the CircleCI orb partnership. I have an action item below for you:

  • Double quote variables

The variable at the line 5 should be double-quoted to comply with SC2086.

Feel free to ask me any questions, and please include me as a reviewer in the PR with the changes. Thank you!
@riywo riywo mentioned this issue Jul 1, 2022
Merged
@riywo riywo closed this as completed in #2 Jul 1, 2022
@riywo
Copy link
Contributor

riywo commented Jul 1, 2022

@EricRibeiro Thank you for such a deep review! I fixed the violation and released v1.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix shellcheck violation autifyhq/autify-circleci-orb-cli
2 participants
@riywo @EricRibeiro