-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for attributes
and precedence
to ConnectionOptions & phone_number
to SignupRequest.
#991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #991 +/- ##
==========================================
+ Coverage 90.28% 90.38% +0.10%
==========================================
Files 105 105
Lines 14126 14341 +215
==========================================
+ Hits 12753 12962 +209
- Misses 975 978 +3
- Partials 398 401 +3
|
acwest
force-pushed
the
add-precedence-to-connection-options
branch
2 times, most recently
from
August 6, 2024 15:48
4be951a
to
72ab1d3
Compare
acwest
reviewed
Aug 6, 2024
…expand changes Signed-off-by: Rajat Bajaj <[email protected]>
duedares-rvj
force-pushed
the
add-precedence-to-connection-options
branch
from
August 7, 2024 10:19
8a16e38
to
b27e4a3
Compare
acwest
previously approved these changes
Aug 7, 2024
acwest
force-pushed
the
add-precedence-to-connection-options
branch
from
August 7, 2024 16:38
970a315
to
24830fb
Compare
acwest
previously approved these changes
Aug 7, 2024
developerkunal
previously approved these changes
Aug 8, 2024
developerkunal
approved these changes
Aug 20, 2024
duedares-rvj
changed the title
Added schema updates on connection module, along with corresponding expand/flatten changes
Add support for Aug 20, 2024
attributes
and precedence
to ConnectionOptions & phone_number
to SignupRequest.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
ConnectionOptions
and includedattributes
andprecedence
📚 References
Required changes have been made in line with the documentation here
Create a connection with attributes
Body Params: options-> attributes
🔬 Testing
make test FILTER= TestAccConnectionOptionsAttr
Relevant test cases and their recordings have been added to ensure changes as described above.
All created resources are cleaned up after the assertions are completed.
- Auth0ConnectionTestCase
📝 Checklist