Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enable_sso and Remove require_pushed_authorization_requests flag support from Tenant Resource. #972

Merged

Conversation

krzysztofdrys
Copy link
Contributor

@krzysztofdrys krzysztofdrys commented Jun 11, 2024

🔧 Changes

  • Add support for property auth0_tenants.flags.enable_ssoin Tenant Resource
  • Remove support for property auth0_tenants.flags.require_pushed_authorization_requests in Tenant Resource

📚 References

#901

🔬 Testing

I included this property in the existing tests.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@krzysztofdrys krzysztofdrys requested a review from a team as a code owner June 11, 2024 09:28
@novotnyjakub
Copy link

+1 on this PR, we are in a need for this too. I was a bit confused at first that the session can be fully configured using Terraform, but then the entire config section can't be enabled.

Thank you for looking into it @krzysztofdrys !

@developerkunal developerkunal changed the title Add support for enable_sso Tenant setting Add enable_sso and Remove require_pushed_authorization_requests Flag Support from Tenant Resource. Jul 15, 2024
@developerkunal developerkunal changed the title Add enable_sso and Remove require_pushed_authorization_requests Flag Support from Tenant Resource. Add enable_sso and Remove require_pushed_authorization_requests flag support from Tenant Resource. Jul 15, 2024
@developerkunal developerkunal requested a review from acwest July 15, 2024 08:11
@developerkunal developerkunal merged commit 469b9cc into auth0:main Jul 15, 2024
6 checks passed
@developerkunal
Copy link
Contributor

Hi @krzysztofdrys,

I hope you're having a great day!

Apologies for the delay in response from our side, and thank you for your valuable contribution. We have thoroughly reviewed and made necessary fixes, updated the test recordings, and everything is now functioning smoothly. The changes have been merged, and they will be included in the upcoming release.

Thank you once again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants