Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-884: Allow client grant scopes to be sent as an empty array #888

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Allow client grant scopes to be sent as an empty array.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@ewanharris ewanharris marked this pull request as ready for review November 30, 2023 11:31
@ewanharris ewanharris requested a review from a team as a code owner November 30, 2023 11:31
@codecov-commenter
Copy link

Codecov Report

Merging #888 (036f5b4) into main (8ce6af1) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #888      +/-   ##
==========================================
+ Coverage   89.99%   90.03%   +0.04%     
==========================================
  Files         101      101              
  Lines       13783    13779       -4     
==========================================
+ Hits        12404    12406       +2     
+ Misses        977      973       -4     
+ Partials      402      400       -2     
Files Coverage Δ
internal/auth0/client/expand.go 91.79% <100.00%> (-0.05%) ⬇️
internal/auth0/client/flatten.go 100.00% <100.00%> (+1.30%) ⬆️

@willvedd willvedd merged commit d50bfd3 into main Nov 30, 2023
6 checks passed
@willvedd willvedd deleted the GH-884-grant-scopes branch November 30, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants