Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent panic when checking for db config secrets #864

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Prevent panic when checking for db config secrets. This could happen when the connection resource does not have any optiosn block defined and we are trying to update it.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner October 19, 2023 13:26
@willvedd
Copy link
Contributor

Does this actually happen in practice? I assumed there were always some connection options defined, regardless of connection type.

@sergiught
Copy link
Contributor Author

I was able to reproduce this with something like:

resource "auth0_connection" "this" {
  name                 = "gh854"
  is_domain_connection = false
  strategy             = "auth0"
  realms               = ["gh854"]
}

As when we expand the options we read them just from the config, not from the state as we use the raw config.

@sergiught sergiught merged commit a0f57f3 into main Oct 20, 2023
4 checks passed
@sergiught sergiught deleted the prevent-panic-in-conn branch October 20, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants