Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-828: Allow creating native apps with device code grant #833

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

As surfaced through #828, when creating a native app with device_code grant, we're unable to create the client directly as this requires the authentication method to get set to none. It's still possible to create the client and then set the auth method to none through the auth0_client_credentials resource, however this requires 2 tf apply commands. This PR improves the DX for creating apps directly with none auth method set when device code grant is set.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner September 15, 2023 10:49
@codecov-commenter
Copy link

Codecov Report

Merging #833 (f86623c) into v1 (f666fdb) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##               v1     #833      +/-   ##
==========================================
- Coverage   89.88%   89.84%   -0.05%     
==========================================
  Files          99       99              
  Lines       13685    13688       +3     
==========================================
- Hits        12301    12298       -3     
- Misses        983      987       +4     
- Partials      401      403       +2     
Files Changed Coverage Δ
internal/auth0/client/expand.go 91.81% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

@sergiught sergiught enabled auto-merge (squash) September 15, 2023 13:50
@sergiught sergiught merged commit 9ff49af into v1 Sep 15, 2023
4 checks passed
@sergiught sergiught deleted the GH-828-none-auth branch September 15, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants