Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding auth0_pages data source #706

Merged
merged 17 commits into from
Jul 12, 2023
Merged

Adding auth0_pages data source #706

merged 17 commits into from
Jul 12, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Jul 11, 2023

🔧 Changes

In lieu of removing the auth0_global_client data source for the next major release (see: #704 , #691), we need to offer a data source that allows the retrieve custom login page. This PR compliments the the auth0_pages resource with a data source.

📚 References

Related PRs

🔬 Testing

Added acceptance test.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@willvedd willvedd requested a review from a team as a code owner July 11, 2023 21:44
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #706 (7f72713) into v1 (1168aaf) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##               v1     #706      +/-   ##
==========================================
+ Coverage   87.60%   87.61%   +0.01%     
==========================================
  Files          84       85       +1     
  Lines       13573    13586      +13     
==========================================
+ Hits        11890    11903      +13     
  Misses       1272     1272              
  Partials      411      411              
Impacted Files Coverage Δ
internal/provider/provider.go 100.00% <ø> (ø)
internal/auth0/page/data_source.go 100.00% <100.00%> (ø)

@willvedd willvedd requested a review from sergiught July 12, 2023 17:06
@willvedd willvedd merged commit 03314e9 into v1 Jul 12, 2023
@willvedd willvedd deleted the auth0-pages-data-source branch July 12, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants