-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding auth0_pages
data source
#706
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e600c0e.
sergiught
suggested changes
Jul 12, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v1 #706 +/- ##
==========================================
+ Coverage 87.60% 87.61% +0.01%
==========================================
Files 84 85 +1
Lines 13573 13586 +13
==========================================
+ Hits 11890 11903 +13
Misses 1272 1272
Partials 411 411
|
sergiught
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
In lieu of removing the
auth0_global_client
data source for the next major release (see: #704 , #691), we need to offer a data source that allows the retrieve custom login page. This PR compliments the theauth0_pages
resource with a data source.📚 References
Related PRs
auth0_pages
resource #691auth0_global_client
resource #704🔬 Testing
Added acceptance test.
📝 Checklist