Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12/X] DXCDT-441: Reintroduce support for office365 client addon #668

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Reintroducing support for office365 client addon on the v1 branch after correctly typing them to the new go-auth0 types.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner June 28, 2023 08:32
@codecov-commenter
Copy link

Codecov Report

Merging #668 (a700043) into feature/DXCDT-441-client-addons-new-relic-11 (47dd453) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                               Coverage Diff                                @@
##           feature/DXCDT-441-client-addons-new-relic-11     #668      +/-   ##
================================================================================
+ Coverage                                         87.17%   87.22%   +0.04%     
================================================================================
  Files                                                80       80              
  Lines                                             12355    12399      +44     
================================================================================
+ Hits                                              10771    10815      +44     
  Misses                                             1211     1211              
  Partials                                            373      373              
Impacted Files Coverage Δ
internal/auth0/client/expand.go 92.76% <100.00%> (+0.26%) ⬆️
internal/auth0/client/flatten.go 96.96% <100.00%> (+0.14%) ⬆️
internal/auth0/client/resource.go 97.51% <100.00%> (+0.06%) ⬆️

@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-new-relic-11 branch 3 times, most recently from c1cb201 to f427ce6 Compare June 29, 2023 07:54
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-office365-12 branch 2 times, most recently from 0d909f3 to ed2627f Compare June 29, 2023 07:57
@sergiught sergiught requested a review from Widcket June 29, 2023 07:57
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-new-relic-11 branch from f427ce6 to 7efd8f5 Compare June 29, 2023 14:42
Base automatically changed from feature/DXCDT-441-client-addons-new-relic-11 to v1 June 29, 2023 14:54
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-office365-12 branch from ed2627f to 6b8ea2a Compare June 29, 2023 14:56
@sergiught sergiught merged commit 9924773 into v1 Jun 29, 2023
@sergiught sergiught deleted the feature/DXCDT-441-client-addons-office365-12 branch June 29, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants