[1/3] DXCDT-243: Improve precision of branding theme fields with float64 instead of int #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
force-pushed
the
patch/DXCDT-243-branding-theme-precision
branch
from
f2a2515 to
9ea746e
Compare
sergiught
changed the title
willvedd
approved these changes
Oct 18, 2022
Widcket
approved these changes
Oct 19, 2022
2 tasks
sergiught
added a commit
that referenced
this pull request
Oct 19, 2022
* Fix update behavior or client_metadata * [1/3] DXCDT-243: Improve precision of branding theme fields with float64 instead of int (#369) Improve precision of branding theme fields with float64 instead of int
sergiught
added a commit
that referenced
this pull request
Oct 19, 2022
…361) * Bump go-auth0 to v0.12.0 * Add validation on identity_api for waad connections * [2/3] DXCDT-234: Fix update behavior of client_metadata (#362) * Fix update behavior or client_metadata * [1/3] DXCDT-243: Improve precision of branding theme fields with float64 instead of int (#369) Improve precision of branding theme fields with float64 instead of int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Change types from int to float32 for increased precision on branding theme fields.
📚 References
🔬 Testing
📝 Checklist