Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXCDT-249: Add client_aliases to client resource #367

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

sergiught
Copy link
Contributor

🔧 Changes

We're adding the client_aliases param for the auth0_client resource as it was missing.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner October 14, 2022 12:14
@sergiught sergiught force-pushed the patch/DXCDT-249-client-aliases branch from e7745b7 to 08e9451 Compare October 14, 2022 12:16
@sergiught sergiught force-pushed the patch/DXCDT-249-client-aliases branch from 08e9451 to 9b67756 Compare October 14, 2022 12:17
@codecov-commenter
Copy link

Codecov Report

Base: 86.81% // Head: 86.83% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (e7745b7) compared to base (de4a0d8).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head e7745b7 differs from pull request most recent head 9b67756. Consider uploading reports for the commit 9b67756 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   86.81%   86.83%   +0.01%     
==========================================
  Files          40       40              
  Lines        8527     8537      +10     
==========================================
+ Hits         7403     7413      +10     
  Misses        863      863              
  Partials      261      261              
Impacted Files Coverage Δ
internal/provider/resource_auth0_client.go 97.17% <100.00%> (+0.03%) ⬆️
internal/provider/structure_auth0_client.go 81.48% <100.00%> (+0.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@willvedd willvedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sergiught sergiught merged commit 3cefe0b into main Oct 17, 2022
@sergiught sergiught deleted the patch/DXCDT-249-client-aliases branch October 17, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants