Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore 404 error when fetching universal login content in branding #359

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Oct 11, 2022

🔧 Changes

An issue with the branding resource got pointed out in #358 after our v0.38.0 release. It turns out we removed by mistake a 404 ignore when fetching the universal login template, so we're adding it back now but also ensuring we properly add tests for that tenant flag check when flattening the struct.

📚 References

🔬 Testing

We are adding additional test cases to cover this part.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

Codecov Report

Base: 86.69% // Head: 86.80% // Increases project coverage by +0.11% 🎉

Coverage data is based on head (c65ea26) compared to base (1150f8f).
Patch coverage: 54.16% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
+ Coverage   86.69%   86.80%   +0.11%     
==========================================
  Files          40       40              
  Lines        8469     8476       +7     
==========================================
+ Hits         7342     7358      +16     
+ Misses        869      858      -11     
- Partials      258      260       +2     
Impacted Files Coverage Δ
internal/provider/resource_auth0_branding.go 83.94% <54.16%> (+4.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sergiught sergiught marked this pull request as ready for review October 11, 2022 17:04
@sergiught sergiught requested a review from a team as a code owner October 11, 2022 17:04
@sergiught sergiught self-assigned this Oct 11, 2022
@sergiught sergiught merged commit ca8a3e0 into main Oct 11, 2022
@sergiught sergiught deleted the patch/issue#358-branding branch October 11, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants