Ignore 404 error when fetching universal login content in branding #359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
An issue with the branding resource got pointed out in #358 after our v0.38.0 release. It turns out we removed by mistake a 404 ignore when fetching the universal login template, so we're adding it back now but also ensuring we properly add tests for that tenant flag check when flattening the struct.
📚 References
🔬 Testing
We are adding additional test cases to cover this part.
📝 Checklist