Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO v2 changes #1075

Merged
merged 11 commits into from
Nov 18, 2024
Merged

SSO v2 changes #1075

merged 11 commits into from
Nov 18, 2024

Conversation

duedares-rvj
Copy link
Contributor

@duedares-rvj duedares-rvj commented Nov 13, 2024

🔧 Changes

  1. Add new attributes name , description, allowed_strategies to auth0_self_service_profile
  2. Add new resource auth0_self_service_profile_custom_text which allow to set custom text for SSO Profile.
resource "auth0_self_service_profile_custom_text" "sso_custom_text" {
  sso_id   = "some-sso-id"
  language = "en"
  page     = "get-started"
  body = jsonencode(
    {
      "introduction" : "Welcome! With only a few steps you'll be able to setup your new custom text."
    }
  )
}

📚 References

https://auth0.com/docs/api/management/v2/self-service-profiles/post-self-service-profiles
https://auth0.com/docs/api/management/v2/self-service-profiles/put-self-service-profile-custom-text

🔬 Testing

Added relevant test
make test-acc FILTER=TestAccSSOCustomText

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@duedares-rvj duedares-rvj requested a review from a team as a code owner November 13, 2024 18:38
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 82.22222% with 24 lines in your changes missing coverage. Please review.

Project coverage is 89.35%. Comparing base (de227d1) to head (8c98e38).

Files with missing lines Patch % Lines
...l/auth0/selfserviceprofile/resource_custom_text.go 81.25% 10 Missing and 5 partials ⚠️
internal/auth0/selfserviceprofile/flatten.go 55.00% 6 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1075      +/-   ##
==========================================
- Coverage   89.41%   89.35%   -0.07%     
==========================================
  Files         126      127       +1     
  Lines       17464    17591     +127     
==========================================
+ Hits        15615    15718     +103     
- Misses       1309     1325      +16     
- Partials      540      548       +8     
Files with missing lines Coverage Δ
internal/auth0/selfserviceprofile/expand.go 81.25% <100.00%> (+1.25%) ⬆️
internal/auth0/selfserviceprofile/resource.go 91.72% <100.00%> (+1.64%) ⬆️
internal/auth0/user/resource.go 75.00% <100.00%> (ø)
internal/auth0/user/resource_role.go 78.00% <100.00%> (ø)
internal/auth0/user/resource_roles.go 80.00% <100.00%> (ø)
internal/provider/provider.go 100.00% <ø> (ø)
internal/auth0/selfserviceprofile/flatten.go 74.57% <55.00%> (-10.04%) ⬇️
...l/auth0/selfserviceprofile/resource_custom_text.go 81.25% <81.25%> (ø)

acwest
acwest previously approved these changes Nov 15, 2024
@duedares-rvj duedares-rvj requested a review from acwest November 15, 2024 20:25
@duedares-rvj duedares-rvj self-assigned this Nov 15, 2024
@duedares-rvj duedares-rvj merged commit ec2597c into main Nov 18, 2024
5 checks passed
@duedares-rvj duedares-rvj deleted the DXCDT-720 branch November 18, 2024 15:40
This was referenced Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants