Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: form, flow expand interface array #1058

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

kushalshit27
Copy link
Contributor

@kushalshit27 kushalshit27 commented Oct 28, 2024

🔧 Changes

Fix: Cannot update form after initial creation

📚 References

#1054
#1057

🔬 Testing

tested by updating form name, nodes, coordinates, start, end

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@kushalshit27 kushalshit27 changed the title fix auth_form expand interface array fix: auth_form expand interface array Oct 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 18.75000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 89.41%. Comparing base (c9e8550) to head (84889b7).

Files with missing lines Patch % Lines
internal/auth0/flow/expand.go 0.00% 8 Missing ⚠️
internal/auth0/form/expand.go 37.50% 4 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1058      +/-   ##
==========================================
+ Coverage   89.36%   89.41%   +0.05%     
==========================================
  Files         126      126              
  Lines       17485    17473      -12     
==========================================
- Hits        15625    15624       -1     
+ Misses       1320     1309      -11     
  Partials      540      540              
Files with missing lines Coverage Δ
internal/auth0/form/expand.go 52.41% <37.50%> (+1.65%) ⬆️
internal/auth0/flow/expand.go 41.26% <0.00%> (+3.58%) ⬆️

@kushalshit27 kushalshit27 marked this pull request as ready for review October 28, 2024 14:07
@kushalshit27 kushalshit27 requested a review from a team as a code owner October 28, 2024 14:07
@duedares-rvj duedares-rvj changed the title fix: auth_form expand interface array Patch: auth_form expand interface array Oct 28, 2024
duedares-rvj
duedares-rvj previously approved these changes Oct 28, 2024
@kushalshit27 kushalshit27 changed the title Patch: auth_form expand interface array Patch: form, flow expand interface array Oct 29, 2024
@kushalshit27 kushalshit27 self-assigned this Oct 30, 2024
@kushalshit27 kushalshit27 merged commit b81a13a into main Oct 31, 2024
5 checks passed
@kushalshit27 kushalshit27 deleted the ESD-41996-forms-update-node branch October 31, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants